RE: [PATCH 1/6] thunderbolt: Updating the register definitions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx]
> Sent: Monday, May 23, 2016 17:40
> To: Levy, Amir (Jer) <amir.jer.levy@xxxxxxxxx>
> Cc: andreas.noever@xxxxxxxxx; bhelgaas@xxxxxxxxxx; linux-
> pci@xxxxxxxxxxxxxxx; Jamet, Michael <michael.jamet@xxxxxxxxx>; Alloun,
> Dan <dan.alloun@xxxxxxxxx>; Westerberg, Mika
> <mika.westerberg@xxxxxxxxx>; Svahn, Kai <kai.svahn@xxxxxxxxx>;
> Shevchenko, Andriy <andriy.shevchenko@xxxxxxxxx>; Winkler, Tomas
> <tomas.winkler@xxxxxxxxx>
> Subject: Re: [PATCH 1/6] thunderbolt: Updating the register definitions
> 
> On Mon, May 23, 2016 at 11:48:51AM +0300, Amir Levy wrote:
> > --- a/include/linux/pci_ids.h
> > +++ b/include/linux/pci_ids.h
> > @@ -2618,6 +2618,8 @@
> >  #define PCI_DEVICE_ID_INTEL_FALCON_RIDGE_2C_BRIDGE  0x156b
> >  #define PCI_DEVICE_ID_INTEL_FALCON_RIDGE_4C_NHI     0x156c
> >  #define PCI_DEVICE_ID_INTEL_FALCON_RIDGE_4C_BRIDGE  0x156d
> > +#define PCI_DEVICE_ID_INTEL_WIN_RIDGE_2C_NHI        0x157d
> > +#define PCI_DEVICE_ID_INTEL_WIN_RIDGE_2C_BRIDGE     0x157e
> >  #define PCI_DEVICE_ID_INTEL_ALPINE_RIDGE_2C_NHI     0x1575 /*
> Thunderbolt 3 */
> >  #define PCI_DEVICE_ID_INTEL_ALPINE_RIDGE_2C_BRIDGE  0x1576
> >  #define PCI_DEVICE_ID_INTEL_ALPINE_RIDGE_4C_NHI     0x1577
> 
> Please read the top of this file for why you shouldn't be adding new ids to it.

I missed the comment in top of this file, just wanted that the thunderbolt device list will be complete. 
I'll revert the 2 new entries.
Note that the instruction in this file wasn't kept even before this patch.

Thanks,
Amir
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux