On Tue, May 17, 2016 at 03:39:59PM -0600, Keith Busch wrote:
> Registers a standard boiler-plate SR-IOV configure callback for NVMe.
>
> Signed-off-by: Keith Busch <keith.busch@xxxxxxxxx>
> ---
> drivers/nvme/host/pci.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index fbe8cc2..8379b9a 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -2033,6 +2033,18 @@ static void nvme_remove(struct pci_dev *pdev)
> nvme_put_ctrl(&dev->ctrl);
> }
>
> +static int nvme_sriov_configure(struct pci_dev *pdev, int numvfs)
> +{
> + int ret = 0;
> +
> + if (numvfs == 0)
> + pci_disable_sriov(pdev);
> + else
> + ret = pci_enable_sriov(pdev, numvfs);
> +
> + return ret ? ret : numvfs;
> +}
I do not subscribe to the belief that every function should have a
single exit. In this case, I think it makes the function much harder
to understand than this:
if (numvfs == 0)
pci_disable_sriov(pdev);
return 0;
}
return pci_enable_sriov(pdev, numvfs);
> #ifdef CONFIG_PM_SLEEP
> static int nvme_suspend(struct device *dev)
> {
> @@ -2127,6 +2139,7 @@ static struct pci_driver nvme_driver = {
> .driver = {
> .pm = &nvme_dev_pm_ops,
> },
> + .sriov_configure = nvme_sriov_configure,
> .err_handler = &nvme_err_handler,
> };
>
> --
> 2.7.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
