Hi, On Tue, May 17, 2016 at 02:37:42PM -0500, Bjorn Helgaas wrote: > [+cc Lukas, Mika] > On Tue, May 17, 2016 at 02:36:02PM -0400, Valdis Kletnieks wrote: > > Seen during boot on next-20160517. This apparently sneaked into the tree > > sometime after -0502 (probably after -0512 but I can't prove it at the moment) > > > > [ 1.806765] INFO: trying to register non-static key. > > [ 1.806772] the code is fine but needs lockdep annotation. > > [ 1.806777] turning off the locking correctness validator. > > [ 1.806786] CPU: 1 PID: 1 Comm: swapper/0 Not tainted 4.6.0-next-20160517-00001-gede618fce89c-dirty #276 > > [ 1.806794] Hardware name: Dell Inc. Latitude E6530/07Y85M, BIOS A17 08/19/2015 > > [ 1.806802] 0000000000000086 000000009200d6c8 ffff88022ca23a90 ffffffffa83f99f3 > > [ 1.806815] 0000000000000000 ffff880223727d40 ffff88022ca23b00 ffffffffa80c1de1 > > [ 1.806826] 0000000000000246 0000000000000000 ffffffffffffffff ffff88022ca23ad8 > > [ 1.806834] Call Trace: > > [ 1.806845] [<ffffffffa83f99f3>] dump_stack+0x68/0x95 > > [ 1.806855] [<ffffffffa80c1de1>] register_lock_class+0x541/0x550 > > [ 1.806861] [<ffffffffa8404b6c>] ? widen_string+0x3c/0xf0 > > [ 1.806870] [<ffffffffa80c4108>] __lock_acquire+0x88/0x1260 > > [ 1.806876] [<ffffffffa840751a>] ? vsnprintf+0x36a/0x520 > > [ 1.806886] [<ffffffffa81bdfc1>] ? kfree_const+0x21/0x30 > > [ 1.806893] [<ffffffffa80c56d1>] lock_acquire+0xb1/0x200 > > [ 1.806904] [<ffffffffa852874e>] ? pm_runtime_no_callbacks+0x1e/0x40 > > [ 1.806915] [<ffffffffa8a07831>] _raw_spin_lock_irq+0x41/0x50 > > [ 1.806923] [<ffffffffa852874e>] ? pm_runtime_no_callbacks+0x1e/0x40 > > [ 1.806932] [<ffffffffa852874e>] pm_runtime_no_callbacks+0x1e/0x40 > > [ 1.806942] [<ffffffffa844fe36>] pcie_port_device_register+0x226/0x560 > > [ 1.806950] [<ffffffffa8450542>] pcie_portdrv_probe+0x32/0xa0 > > Probably introduced by this: > > http://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?id=0195d2813547 > > I dropped the pci/pm branch for now. Okay this is caused by pm_runtime_no_callbacks() acquiring dev->power.lock before spin_lock_init() has been called. The spinlock is initialized in device_pm_init_common(), which is called from device_pm_init(), which is called from device_initialize(), which is the first half of device_register(). The solution is to either (1) move the call to pm_runtime_no_callbacks() after the call to device_register() or (2) replace the call to device_register() with calls to device_initialize() and device_add(), then move the call to pm_runtime_no_callbacks() in-between. I can barely keep my eyes open right now, I'll look at this with a fresh pair of eyeballs tomorrow and cook up, test and submit a fixup patch unless Mika or someone else has already done it until then. Thank you Valdis for spotting this. Best regards, Lukas -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
