On Wednesday 11 May 2016 09:36:58 Tomasz Nowicki wrote: > > > > I understand that this moves code around, but those in-function > > #ifdefs aren't nice. Any chance to get rid of them but putting whole > > functions under the #ifdef? > > > > This is a __weak implementation, so assuming I would move #ifdef out of > function I need to provide another empty __weak stub. I do not know > which solution is more ugly. In any case we can do that cleanup separately. > I'd vote for just dropping the __weak here, given that there is no non-weak implementation. If we end up needing to override this for some architecture or host bridge in the future, we can think about how to best do that then. I agree that should be a separate patch, this one should only move code from one file to another. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
