Re: Build warning regression (104daa71b396 ("PCI: Determine actual VPD size on first access"))

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[+cc Geert]

On Tue, May 10, 2016 at 08:09:53AM +0200, Hannes Reinecke wrote:
> On 05/09/2016 09:54 PM, Bjorn Helgaas wrote:
> > Hi Hannes,
> > 
> > Geert's list of build regressions and improvements
> > (http://lkml.kernel.org/r/1462782250-6231-1-git-send-email-geert@xxxxxxxxxxxxxx)
> > shows these new warnings:
> > 
> >   drivers/pci/access.c: warning: format '%zu' expects argument of type 'size_t', but argument 4 has type 'unsigned int' [-Wformat=]:  => 318:8
> >   drivers/pci/access.c: warning: format '%zu' expects argument of type 'size_t', but argument 5 has type 'unsigned int' [-Wformat=]:  => 340:6
> > 
> > which I think are due to 104daa71b396 ("PCI: Determine actual VPD size on
> > first access").
> > 
> > Would you mind fixing those up and sending me a patch?  These were in
> > the v4.6-rc1 regressions email, and I should have noticed then, but I
> > didn't.
> > 
> This is curious.
> The code has this:
> 
> size_t off = 0;
> 
> ...
> 
> dev_warn(&dev->dev,
> 	"invalid large VPD tag %02x size at offset %zu",
> 	tag, off + 1);
> 
> Which, as per my reading, suggests that the last argument to
> dev_warn() is of type size_t.
> 
> Which tree has generated the above warning?

Yeah, it wasn't obvious to me how this would happen either.  From
Geert's original email, I think the tree is v4.6-rc7, i.e.,
44549e8f5eea4e0a41b487b63e616cb089922b99.

Geert, can you tell which config generated this warning?
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux