On Tuesday 03 May 2016 11:04:23 Liviu.Dudau@xxxxxxx wrote: > > > + list_splice_init(&bridge->windows, &resources); > > > + b->sysdata = bridge->sysdata; > > > > Does the sysdata not become effectively obsolete after this series? My > > understanding is that it's primarily used to store driver-specific data > > along with a PCI bus, but if drivers can embed struct pci_host_bridge > > they can simply upcast bus->bridge. > > I second that. If we do this change (which is long overdue and I fully support), > let's kill sysdata now. Generic host bridge code doesn't use sysdata on purpose. I think we still need it in the intermediate time for any remaining users of the existing interfaces (pci_scan_bus, pci_scan_root_bus, pci_create_root_bus). It may take a while until those are all gone, but I agree that it makes sense to not even set the pointer for any driver we convert to the new interface. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
