Re: [PATCH] Revert "PCI: imx6: Add support for active-low reset GPIO"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Mar 27, 2016 at 5:49 PM, Fabio Estevam <festevam@xxxxxxxxx> wrote:
> From: Fabio Estevam <fabio.estevam@xxxxxxx>
>
> Commit 5c5fb40de8f14 ("PCI: imx6: Add support for active-low reset GPIO")
> has the following issues:
>

Hi Fabio,

I agree with reverting this - this patch does break PCI for all the
Gateworks Ventana boards.

It's Gateworks 'Ventana' here that uses IMX6 PCI, not Laguna so your
comment is wrong. Also, Ventana boards 'do' have their PCI reset
properly defined as active-low so we probably shouldn't refer to
Gateworks Ventana having gpio polarity not specified in the
device-tree.

It is the fact that the gpio polarity has the wrong logic level in
that patch which breaks things. I think your second point is really
the problem that needs to be mentioned for the reason of the revert.

Other than that you can add a 'Tested-by: Tim Harvey
<tharvey@xxxxxxxxxxxxx>' in reference to Gateworks Ventana PCI.

Thanks,

Tim
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux