On Fri, Feb 26, 2016 at 10:00 PM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote: > From: Joao Pinto <Joao.Pinto@xxxxxxxxxxxx> > > Several DesignWare-based drivers (dra7xx, exynos, imx6, keystone, qcom, and > spear13xx) had similar loops waiting for the link to come up. > > Add a generic dw_pcie_wait_for_link() for use by all these drivers so the > waiting is done consistently, e.g., always using usleep_range() rather than > mdelay() and using similar timeouts and retry counts. > > Note that this changes the Keystone link training/wait for link strategy, > so we initiate link training, then wait longer for the link to come up > before re-initiating link training. > > [bhelgaas: changelog, split into its own patch, update pci-keystone.c, pcie-qcom.c] > Signed-off-by: Joao Pinto <jpinto@xxxxxxxxxxxx> > Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> 5 retries should be sufficient for keystone, still it would be good to have a tested-by for it. Other than that code seems fine to me. Acked-by: Pratyush Anand <pratyush.anand@xxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
