On Mon, Feb 15, 2016 at 02:56:38PM +0530, Jayachandran C wrote:
> Handle two quirks of the PCI controller on Broadcom's Vulcan processor.
> - Mark internal bridges so that they are skipped during DMA alias
> search.
> - Skip BAR0 resource assignment for internal bridges. The BARs
> of internal bridges should not be assigned from the mem resource
> range.
>
> Signed-off-by: Jayachandran C <jchandra@xxxxxxxxxxxx>
> ---
>
> Resending, last patch was missing the Signed-off-by, also fixed the
> comment a bit.
If you resend a patch, please increment the version number and resend
the entire series, no matter how minor the change was. Version
numbers are free, and it's a hassle for me to sort out multiple
versions labeled with the same number.
> JC.
>
> drivers/pci/quirks.c | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 0575a1e..afc186a 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -3705,6 +3705,27 @@ DECLARE_PCI_FIXUP_HEADER(0x1283, 0x8892, quirk_use_pcie_bridge_dma_alias);
> DECLARE_PCI_FIXUP_HEADER(0x8086, 0x244e, quirk_use_pcie_bridge_dma_alias);
>
> /*
> + * Two levels of bridges in Broadcom Vulcan are not real PCI or PCIe bridges.
> + * These are internal bridges and should not be used for dma alias
> + * calculations. Additionally, the BAR0 of thes bridges should not be
> + * assigned with a mem resource from linux
> + */
> +static void quirk_bridge_brcm_vulcan_internal(struct pci_dev *pdev)
> +{
> + struct resource *r = &pdev->resource[0];
> +
> + /* skip from alias search */
> + pdev->dev_flags |= PCI_DEV_FLAGS_BRIDGE_SKIP_ALIAS;
> +
> + /* clear BAR0, should not be used from Linux */
> + memset(r, 0, sizeof(*r));
This definitely needs some explanation. The whole point of the
architected PCI config space header is so that generic OS code can
manage the device without having to add device-specific code.
Are you saying the register at 0x10 in config space is not actually a
BAR at all? Or it is a BAR, but you don't think anybody should need
to use it? BARs do not have enable bits, so no matter what value is
in the BAR, that value defines address space to which the device will
respond. Linux needs to know about that, even if no driver actually
uses it.
> +}
> +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_BROADCOM, 0x9000,
> + quirk_bridge_brcm_vulcan_internal);
> +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_BROADCOM, 0x9039,
> + quirk_bridge_brcm_vulcan_internal);
> +
> +/*
> * Intersil/Techwell TW686[4589]-based video capture cards have an empty (zero)
> * class code. Fix it.
> */
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
