On Tue, Jan 26, 2016 at 12:04:47PM +0000, Lawrynowicz, Jacek wrote: > > -----Original Message----- > > From: David Woodhouse [mailto:dwmw2@xxxxxxxxxxxxx] > > Sent: Tuesday, January 26, 2016 12:59 PM > > To: Lawrynowicz, Jacek <jacek.lawrynowicz@xxxxxxxxx>; linux- > > pci@xxxxxxxxxxxxxxx > > Cc: bhelgaas@xxxxxxxxxx; alex.williamson@xxxxxxxxxx; jroedel@xxxxxxx > > Subject: Re: [PATCH v2 1/2] pci: Add support for multiple DMA aliases > > > > On Tue, 2016-01-26 at 11:31 +0100, Jacek Lawrynowicz wrote: > > > > > > +bool pci_dma_alias_is_enabled(struct pci_dev *dev, u8 devfn) > > > +{ > > > + return dev->dma_alias_mask && > > > + test_bit(devfn, dev->dma_alias_mask); > > > +} > > > +EXPORT_SYMBOL_GPL(pci_dma_alias_is_enabled); > > > > Why export this? > > So it can be used in drivers/iommu/iommu.c in get_pci_alias_group(). > Bjorn didn't want dma_alias_mask to be used there directly. Declaring pci_dma_alias_is_enabled() in include/linux/pci.h is sufficient to allow drivers/iommu/iommu.c to use it. The EXPORT_SYMBOL_GPL() is not needed. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
