On Thursday 14 January 2016 10:51:32 Vineet Gupta wrote: > >> > >> A somewhat nicer method would be to have callback pointers in struct > >> pci_host_bridge, and call those when they are non-NULL so we can > >> remove the global pcibios_* functions from the API. That would also > >> bring us a big step closer to having PCI support itself as a loadable > >> module, and it would better reflect that those functions are really > >> host bridge specific rather than architecture specific. When you use > >> the same host bridge on multiple architectures, you typically have > >> the same requirements for hacks in there, but each architectures may > >> need to support multiple host bridges with different requirements. > > Since we will be constantly improving the driver and the core itself, I suggest > > that this functions be made __weak and in an update we can turn it struct > > pointers just like Arnd suggested. Is this good for you? > > There is no point in making it weak, w/o a fallback version in generic code. For > this series, I suggest you just remove the straggler EXPORT_SYMBOL and respin. > To clarify: I don't particularly like __weak functions anywhere, but they are already common in drivers/pci, so we can add a couple more to reach the goal of removing all architecture specific code. However, there should never be a reason to add a __weak function in arch code that gets overridden by common code, that would be very confusing and not helpful. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
