Re: i.MX6 PCI GPR8 Settings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Mittwoch, den 13.01.2016, 14:34 -0200 schrieb Fabio Estevam:
> On Wed, Jan 13, 2016 at 2:14 PM, Justin Waters
> <justin.waters@xxxxxxxxxxx> wrote:
> > Hello,
> >
> > I've been working with a custom board based on an i.MX6, and noticed
> > that the GPR8 settings for the PCIe pins are hard coded to specific
> > values. We would like to customize these values for our specific
> > hardware.
> >
> > While it's certainly possible to simply change the hard coding, it
> > strikes me that these should most likely be configurable via the
> > device tree. My initial thinking would be to create a number of
> > properties that would be defined in a dts file, e.g.
> > fsl,pci-deemph-gen1 = < 0>, but perhaps there's a better way to handle
> > this. I'm happy to put something together, but I'd like to know that
> > I'm on the right track. I'd appreciate any feedback.
> 
> Looks like a good idea.
> 
> Adding Lucas for his comments.

Thanks for looping me in Fabio.

Adding optional DT properties while keeping the current behavior as the
default sounds like the right thing to do. I'll happily review patches
once you got them.

Regards,
Lucas
-- 
Pengutronix e.K.             | Lucas Stach                 |
Industrial Linux Solutions   | http://www.pengutronix.de/  |

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux