Sean,
I think this is a good addition.
I don't plan on merging it into my patch, but instead think it should be
applied separately
Thanks,
David Daney
On 12/16/2015 04:55 PM, Sean O. Stalley wrote:
From 484344fef7e5c96c54576586ce81e6209a48b92c Mon Sep 17 00:00:00 2001
From: "Sean O. Stalley" <sean.stalley@xxxxxxxxx>
Date: Wed, 16 Dec 2015 10:31:51 -0800
Subject: [PATCH 1/1] Support region sizes that are not power-of-2
Enhanced Allocation allows PCI devices to reserve regions with DWORD
granularity. Make sure lspci doesn't tuncate least significant bits
of the region size.
ex: a 2000 byte region should display [size=2000] instead of [size=1K]
Signed-off-by: Sean O. Stalley <sean.stalley@xxxxxxxxx>
---
Hi David,
Here are some additional changes I think we should make to lspci in order to support EA.
The truncation problem was a simple fix.
Regions described by EA are being mislabeled as [virtual].
I spent some time today trying to write a patch that fixes this issue.
I couldn't come up with a clean solution, so I just added a comment.
Let me know if you have any questions.
Thanks,
Sean
lspci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lspci.c b/lspci.c
index fe7b7fe..d483f3a 100644
--- a/lspci.c
+++ b/lspci.c
@@ -336,7 +336,7 @@ show_size(pciaddr_t x)
if (!x)
return;
for (i = 0; i < (sizeof(suffix) / sizeof(*suffix) - 1); i++) {
- if (x < 1024)
+ if (x % 1024)
break;
x /= 1024;
}
@@ -366,7 +366,7 @@ show_bases(struct device *d, int cnt)
putchar('\t');
if (pos && !flg) /* Reported by the OS, but not by the device */
{
- printf("[virtual] ");
+ printf("[virtual] "); /* could also be enhanced */
flg = pos;
virtual = 1;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
