Hi Wolfram, On 17 December 2015 13:33, Wolfram Sang wrote: > > + rcar_pci_write_reg(pcie, 0x000f0030, GEN2_PCIEPHYADDR); > > + rcar_pci_write_reg(pcie, 0x00381203, GEN2_PCIEPHYDATA); > > + rcar_pci_write_reg(pcie, 0x00000001, GEN2_PCIEPHYCTRL); > > + rcar_pci_write_reg(pcie, 0x00000006, GEN2_PCIEPHYCTRL); > > + > > + rcar_pci_write_reg(pcie, 0x000f0054, GEN2_PCIEPHYADDR); > > + /* The following value is for DC connection, no termination resistor */ > > + rcar_pci_write_reg(pcie, 0x13802007, GEN2_PCIEPHYDATA); > > + rcar_pci_write_reg(pcie, 0x00000001, GEN2_PCIEPHYCTRL); > > + rcar_pci_write_reg(pcie, 0x00000006, GEN2_PCIEPHYCTRL); > > I'd vote for a comment saying where these magic values come from, i.e. > which manual, which chapter, etc... Ok, will do. Thanks Phil -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html