On Sat, Dec 12, 2015 at 08:41:53PM -0500, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/pci/host/Kconfig:config PCI_TEGRA > drivers/pci/host/Kconfig: bool "NVIDIA Tegra PCIe controller" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > We don't have to disallow a driver unbind, since that is already > done for us in this driver. > > Since module_platform_driver() uses the same init level priority as > builtin_platform_driver() the init ordering remains unchanged with > this commit. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > was (or is now) contained at the top of the file in the comments. > > Cc: Thierry Reding <thierry.reding@xxxxxxxxx> > Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > Cc: Stephen Warren <swarren@xxxxxxxxxxxxx> > Cc: Alexandre Courbot <gnurou@xxxxxxxxx> > Cc: linux-tegra@xxxxxxxxxxxxxxx > Cc: linux-pci@xxxxxxxxxxxxxxx > Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> > --- > drivers/pci/host/pci-tegra.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) I'd rather not do this. There is work underway to make it possible to turn PCI host drivers into modules. I have a local tree with the necessary changes and, though I suspect it might take a few releases to get everything merged, I think we'll get there eventually. Thierry
Attachment:
signature.asc
Description: PGP signature
