Hi Thomas, I just went with checkpatch.pl approach I hope this patch didn’t ruin your day :) { name: Bogicevic Sasa phone: +381606006200 } > On Dec 12, 2015, at 13:23, Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx> wrote: > > Dear Bogicevic Sasa, > > On Sat, 12 Dec 2015 03:41:48 -0800, Bogicevic Sasa wrote: >> This fixes few warnings about missing line after declarations and one >> no whitespace is necesarry before that "(" >> >> Signed-off-by: Bogicevic Sasa <brutallesale@xxxxxxxxx> > > I am not a big fan of this struct rule that insists in having an empty > line after declarations, I believe when a for() loop or if() condition > has only one line of declaration and one line of useful code, it > doesn't make much sense. But oh well, that's the rule, so let's do it > this way. > >> --- >> drivers/pci/host/pci-imx6.c | 2 +- >> drivers/pci/host/pci-mvebu.c | 3 +++ >> drivers/pci/host/pcie-rcar.c | 2 ++ >> 3 files changed, 6 insertions(+), 1 deletion(-) > > For the pci-mvebu.c part: > > Reviewed-by: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx> > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html