On Fri, Dec 11, 2015 at 12:07:03AM +0100, sasa bogicevic wrote:
> I wanted to start with approach one error one folder so I did “space prohibited before ,” in just hotplug folder. I used checkpatch script to see if I nailed it and the output was fine.
> When I do grep -rl I also get the same result eventhou when I look at the, for example, drivers/pci/hotplug/shpchp_ctrl.c there is no space before comma anywhere. I double checked it. I didn’t do header files unfortunately so that errors are expected I guess.
>
> ./scripts/checkpatch.pl --file --terse drivers/pci/hotplug/shpchp_ctrl.c
> drivers/pci/hotplug/shpchp_ctrl.c:190: WARNING: Block comments use * on subsequent lines
> drivers/pci/hotplug/shpchp_ctrl.c:264: WARNING: line over 80 characters
> drivers/pci/hotplug/shpchp_ctrl.c:265: WARNING: line over 80 characters
> drivers/pci/hotplug/shpchp_ctrl.c:344: ERROR: return is not a function, parentheses are not required
> drivers/pci/hotplug/shpchp_ctrl.c:359: ERROR: return is not a function, parentheses are not required
> drivers/pci/hotplug/shpchp_ctrl.c:439: WARNING: Possible unnecessary 'out of memory' message
> drivers/pci/hotplug/shpchp_ctrl.c:463: WARNING: space prohibited between function name and open parenthesis '('
> drivers/pci/hotplug/shpchp_ctrl.c:478: WARNING: space prohibited between function name and open parenthesis '('
> drivers/pci/hotplug/shpchp_ctrl.c:569: WARNING: space prohibited between function name and open parenthesis '('
> drivers/pci/hotplug/shpchp_ctrl.c:626: WARNING: space prohibited between function name and open parenthesis ‘('
> total: 2 errors, 8 warnings, 730 lines checked
>
> I used objdiff to record and see if I didn’t change anything and I got no output so I guess all is good, don’t know why grep finds “ ,” it is a mystery to me since I am on my working branch, looking at a file and it is not there. Can you also take a look on your side ?
>
> I wanted to do one small thing and when I see that it is good and accepted from you then do all warnings and errors one by one.
OK, makes sense. I think you're on the right track, and if you extend
this patch to all of drivers/pci, I'll apply it.
I see you found the lines that checkpatch didn't complain about.
Maybe checkpatch doesn't look at things inside quoted strings? That's
just a guess; I don't use checkpatch regularly.
If you plan to do other things, e.g., removing spaces between the
function name and open parenthesis, I'd like to have all the "white
space-only" changes in a single patch.
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
