Re: Resizeable PCI BAR support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Christian,

[auto build test WARNING on pci/next]
[also build test WARNING on v4.4-rc3 next-20151203]

url:    https://github.com/0day-ci/linux/commits/Christian-K-nig/Resizeable-PCI-BAR-support/20151205-204542
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
reproduce: make htmldocs

All warnings (new ones prefixed by >>):

   lib/crc32.c:148: warning: No description found for parameter 'tab)[256]'
   lib/crc32.c:148: warning: Excess function parameter 'tab' description in 'crc32_le_generic'
   lib/crc32.c:293: warning: No description found for parameter 'tab)[256]'
   lib/crc32.c:293: warning: Excess function parameter 'tab' description in 'crc32_be_generic'
   lib/crc32.c:1: warning: no structured comments found
>> drivers/pci/pci.c:2735: warning: No description found for parameter 'pdev'
>> drivers/pci/pci.c:2735: warning: Excess function parameter 'dev' description in 'pci_rbar_get_sizes'
   drivers/pci/pci.c:2774: warning: No description found for parameter 'pdev'
>> drivers/pci/pci.c:2774: warning: Excess function parameter 'dev' description in 'pci_rbar_set_size'

vim +/pdev +2735 drivers/pci/pci.c

  2729	 * @bar: BAR to query
  2730	 *
  2731	 * Get the possible sizes of a resizeable BAR as bitmask defined in the spec
  2732	 * (bit 0=1MB, bit 19=512GB). Returns 0 if BAR isn't resizeable.
  2733	 */
  2734	u32 pci_rbar_get_sizes(struct pci_dev *pdev, int bar)
> 2735	{
  2736		int pos, nbars;
  2737		u32 ctrl, cap;
  2738		int i;
  2739	
  2740		pos = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_REBAR);
  2741		if (!pos)
  2742			return 0x0;
  2743	
  2744		pci_read_config_dword(pdev, pos + PCI_REBAR_CTRL, &ctrl);
  2745		nbars = (ctrl & PCI_REBAR_CTRL_NBAR_MASK) >> PCI_REBAR_CTRL_NBAR_SHIFT;
  2746	
  2747		for (i = 0; i < nbars; ++i, pos += 8) {
  2748			int bar_idx;
  2749	
  2750			pci_read_config_dword(pdev, pos + PCI_REBAR_CTRL, &ctrl);
  2751			bar_idx = (ctrl & PCI_REBAR_CTRL_BAR_IDX_MASK) >>
  2752					PCI_REBAR_CTRL_BAR_IDX_SHIFT;
  2753			if (bar_idx != bar)
  2754				continue;
  2755	
  2756			pci_read_config_dword(pdev, pos + PCI_REBAR_CAP, &cap);
  2757			return (cap & PCI_REBAR_CTRL_SIZES_MASK) >>
  2758				PCI_REBAR_CTRL_SIZES_SHIFT;
  2759		}
  2760	
  2761		return 0x0;
  2762	}
  2763	
  2764	/**
  2765	 * pci_rbar_set_size - set a new size for a BAR
  2766	 * @dev: PCI device
  2767	 * @bar: BAR to set size to
  2768	 * @size: new size as defined in the spec.
  2769	 *
  2770	 * Set the new size of a BAR as defined in the spec (0=1MB, 19=512GB).
  2771	 * Returns true if resizing was successful, false otherwise.
  2772	 */
  2773	bool pci_rbar_set_size(struct pci_dev *pdev, int bar, int size)
> 2774	{
  2775		int pos, nbars;
  2776		u32 ctrl;
  2777		int i;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: Binary data


[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux