Re: [PATCH 2/2] PCI support added to ARC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bjorn,

On 11/25/2015 4:46 PM, Bjorn Helgaas wrote:
> On Wed, Nov 25, 2015 at 05:25:37AM +0000, Vineet Gupta wrote:
>> On Tuesday 24 November 2015 08:02 PM, Joao Pinto wrote:
> 
>>> +			pr_err("PCI: Device %s not available because"/
>>> +			       " of resource collisions\n", pci_name(dev));
>>
>> Better not to break strings - even if they sometime exceed line sz limit of 80.
>> You could anyways reduce the string content herer.
> 
> Also use dev_err() instead of pr_err().
> 

Thanks for the review. Could you please check PATCH 1/2 regarding the new
platform driver? This way I would produce a v2 of the patch set.

Thanks,
Joao

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux