Re: [PATCH V4 7/8] PCI: OF: Move of_pci_dma_configure() to pci_dma_configure()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hanjun,

On 10/24/15 02:44, Hanjun Guo wrote:
Hi Suravee,

Some minor comments  below:

On 2015/10/21 23:52, Suravee Suthikulpanit wrote:
[...]
diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index eea8b42..09264f8 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -6,12 +6,14 @@
  #include <linux/delay.h>
  #include <linux/init.h>
  #include <linux/pci.h>
-#include <linux/of_pci.h>
+#include <linux/of_device.h>

Seems it's needed for GICv2m patch but not this one?
This one is needed since we are making use of the new of_dma_configure instead of the of_pci_dma_configure.


  #include <linux/pci_hotplug.h>
  #include <linux/slab.h>
  #include <linux/module.h>
  #include <linux/cpumask.h>
  #include <linux/pci-aspm.h>
+#include <linux/acpi.h>

I think acpi.h should be introduced by the next patch.
You are right. I'll update this one.


+#include <linux/property.h>

And property.h is also not needed for this patch set.

You are right. I'll remove this

Thanks,
Suravee


--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux