On Tue, Oct 27, 2015 at 06:06:54PM -0500, Bjorn Helgaas wrote: >On Mon, Oct 26, 2015 at 11:15:51AM +0800, Wei Yang wrote: >> During EEH recovery, hotplug is applied to the devices which don't >> have drivers or their drivers don't support EEH. However, the hotplug, >> which was implemented based on PCI bus, can't be applied to VF directly. >> >> The patch renames virtn_{add,remove}() and exports them so that they >> can be used in PCI hotplug during EEH recovery. > >Trivial, but write this as an imperative sentence, e.g., > > Rename virtn_{add,remove}() and export them so they > can be used in PCI hotplug during EEH recovery. > >"The patch" doesn't add any useful information; it's obvious that the >changelog applied to this patch. Yep, thanks, will change in next version. > >This comment also applies to at least the next patch. > >Bjorn -- Richard Yang Help you, Help me -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html