On Tue, Oct 27, 2015 at 2:20 PM, Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > Well, maybe. Are those states documented in the DesignWare spec? I Unfortunately I cannot find them in DesignWare spec that I have access to. > don't want to put things in pcie-designware.h that are only common by > accident or even by convention. We should only put things there if > they are documented things that users of that IP can rely on. > > LTSSM_MASK is documented in the TI Keystone spec, so its definition > probably belongs in pci-keystone-dw.c. The same TI spec also contains > LTSSM state definitions, so I suspect they're in the same boat -- > things that might accidentally be the same across devices, but they > don't *have* to be. > > So I'm going to drop the following patches from my tree for now: > > 1ad5fdbc8410 PCI: designware: Add LTSSM state definitions > b09464f77dd2 PCI: designware: Use common LTSSM_STATE_L0 definition > fa15c15fd95d PCI: designware: Use common LTSSM_STATE_RCVRY_LOCK definition > 4788fe6ebf45 PCI: designware: Use common LTSSM_STATE_MASK definition > > We can add pieces back if they make sense. If we add things to shared > files like pcie-designware.h, I'd like a reference to the DW spec that > justifies the sharing. Fair enough, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
