On 16/10/15 06:46, Jiang Liu wrote: > On 2015/10/15 23:39, Marc Zyngier wrote: >> As we're going to have multiple paths to allocate/free the >> platform-msi private data, factor this out into separate >> utility functions. >> >> Signed-off-by: Marc Zyngier <marc.zyngier@xxxxxxx> >> --- >> drivers/base/platform-msi.c | 84 ++++++++++++++++++++++++++------------------- >> 1 file changed, 48 insertions(+), 36 deletions(-) >> >> diff --git a/drivers/base/platform-msi.c b/drivers/base/platform-msi.c >> index 6148c78..92666cd 100644 >> --- a/drivers/base/platform-msi.c >> +++ b/drivers/base/platform-msi.c >> @@ -189,21 +189,11 @@ struct irq_domain *platform_msi_create_irq_domain(struct fwnode_handle *fwnode, >> return domain; >> } >> >> -/** >> - * platform_msi_domain_alloc_irqs - Allocate MSI interrupts for @dev >> - * @dev: The device for which to allocate interrupts >> - * @nvec: The number of interrupts to allocate >> - * @write_msi_msg: Callback to write an interrupt message for @dev >> - * >> - * Returns: >> - * Zero for success, or an error code in case of failure >> - */ >> -int platform_msi_domain_alloc_irqs(struct device *dev, unsigned int nvec, >> - irq_write_msi_msg_t write_msi_msg) >> +static int platform_msi_alloc_priv_data(struct device *dev, unsigned int nvec, >> + irq_write_msi_msg_t write_msi_msg, >> + struct platform_msi_priv_data **data) > How about making platform_msi_alloc_priv_data() return a pointer > instead of an int, that may simplify the code a bit. > That's a good point. I could encode the error code in the return pointer (PTR_ERR). Thanks, M. -- Jazz is not dead. It just smells funny... -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
