On 10/05/2015 06:53 AM, Fabio Estevam wrote:
From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
Designware PCI block uses 0x3f for the LTSSM_STATE_MASK.
Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
---
Changes since v1:
- Fix Subject
Murali,
I am doing some consolidation on the PCI DW drivers and I noticed that
keystone uses a different LTSSM_STATE_MASK definition.
Could you please double check it?
drivers/pci/host/pci-keystone-dw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/host/pci-keystone-dw.c b/drivers/pci/host/pci-keystone-dw.c
index 3cf55cd..78320e4 100644
--- a/drivers/pci/host/pci-keystone-dw.c
+++ b/drivers/pci/host/pci-keystone-dw.c
@@ -25,7 +25,7 @@
/* Application register defines */
#define LTSSM_EN_VAL 1
-#define LTSSM_STATE_MASK 0x1f
+#define LTSSM_STATE_MASK 0x3f
NACK
The mask should be 0x1f as was originally as per document
4-0 LTSSM_STATE
LTSSM current state. Please see Appendix
A.1 for the names of the LTSSM states corresponding to
the encoded values.
refer the document at http://www.ti.com/lit/ug/sprugs6d/sprugs6d.pdf
Murali
#define LTSSM_STATE_L0 0x11
#define DBI_CS2_EN_VAL 0x20
#define OB_XLAT_EN_VAL 2
--
Murali Karicheri
Linux Kernel, Keystone
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html