Hi Lucas, On Mon, Oct 12, 2015 at 7:19 AM, Lucas Stach <l.stach@xxxxxxxxxxxxxx> wrote: > Am Donnerstag, den 08.10.2015, 22:48 -0300 schrieb Fabio Estevam: >> From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> >> >> Move LTSSM state definitions to common pcie-designware.h so that other >> drivers can make use of them. >> >> Also, in order to avoid name collision define LTSSM_STATE_MASK_KS, as >> keystone uses a different LTSSM mask. >> > Why? Is this some kind of difference between the DW PCIe core revisions? This patch does not alter the LTSSM masks that are used currently and they match the ones stated in the SoC manuals. For keystone: http://www.ti.com/lit/ug/sprugs6d/sprugs6d.pdf Section "48.9.11 Debug Register 0 (PCIE_PL_DEBUG0)" shows that LTSSM current state has 6 bits. For i.MX6: Section "3.9.11 Debug 0 Register (DEBUG0)" shows that LTSSM_STATE field has 5 bits. Regards, Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html