Re: [RFC PATCHv2] x86/pci: Initial commit for new VMD device driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 9 Oct 2015, Bjorn Helgaas wrote:
Given that domain_nr is a 32-bit integer, APCI's _SEG is only 16 bits,
and the pci domain is purely a software construct, do you see any problem
if we start these 'special' domains at 0x10000? I've tested this in
the driver and lspci + setpci with the single line update in pciutils'
lib/pci.h, and it all seems to work just fine.

If you make the kernel start using domain numbers that don't fit in 16
bits, what happens if you run the old lspci on a new kernel?

If VMD is enabled and enumerated by the driver with this proposal,
older versions of pciutils will not work; lspci will exit with error
status for being unable to find the sysfs entry for devices in that
domain since the upper bits are truncated in the down cast.

Assuming we can change pciutils to use 'int' for domain, and have a
driver for this new device merged in the near future, I'm not too worried
about users and distros with older utils. I don't think this a device
someone could turn on by accident, so their shouldn't be any fallout if
I properly communicate the dependencies to those who do want to enable it.
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux