On 09/29/2015 12:42 AM, Arnd Bergmann wrote:
On Monday 28 September 2015 17:56:24 David Daney wrote:
From: David Daney <david.daney@xxxxxxxxxx>
Early versions of the Cavium Thunder CN88XX processor are missing
Enhanced Allocation (EA) capabilities for the fixed BAR addresses used
by the on-SoC hardware blocks.
Add config access functions that synthesize the missing EA
capabilities for versions that are missing that information. Since
this is a little hacky, gate the inclusion of the code with a new
Kconfig variable.
Signed-off-by: David Daney <david.daney@xxxxxxxxxx>
---
As suggested by Bjorn Helgaas... It is RFC at this point, but this is
working well for me.
I don't have an opinion on the way you implement the config space
accessors, but it seems that the overall amount of code is comparable
to the normal pci-host-generic driver without this,
That is not a correct interpretation of the patch. We need *both*
files. So if we, hypothetically, duplicated the contents of
pci-host-generic.c and combined it with the new
thunder_ecam_config_io.c, the result would be over twice as much code.
That doesn't even address the anti-pattern of making many copies of the
common code (unfactoring?) found in pci-host-generic.c I am not even
going to attempt such a thing as it would surely receive many NAKs.
and it is not
really generic at all.
The "generic" part of that driver really refers to the framework of
parsing the OF device tree, mapping the config space address windows and
creating and scanning of the PCI buses. It already contains several
specializations of config space accessors, my patch just adds an
additional config space accessor.
I think because of this, it makes more sense to have a separate top-level
driver for this and not reuse the pci-host-generic implementation here.
I will not do that, as some of our first attempts at getting PCI support
merged used that strategy, and were NAKed for being reimplementations of
pci-host-generic.c
The current thinking on Cavium ThunderX on-SoC PCI buses really consists
of two options:
1) Use pci-host-generic.c with existing ECAM config space accessors.
Set PCI_PROBE_ONLY, and then enumerate and assign BARs for all external
PCIe devices in firmware.
2) Use pci-host-generic.c with this new EA synthesizing config space
accessor.
My interpretation of Bjorn Helgaas' suggestion was to do #2, and the
first attempt at this is this patch.
David Daney
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
