Hi Gerald, thanks for your patch. It looks pretty good and addresses my previous review comments. I have a few questions, first one is how this operates with DMA-API on s390. Is there a seperate DMA-API implementation besides the IOMMU-API one for PCI devices? My other question is inline: On Thu, Aug 27, 2015 at 03:33:03PM +0200, Gerald Schaefer wrote: > +struct s390_domain_device { > + struct list_head list; > + struct zpci_dev *zdev; > +}; Instead of using your own struct here, have you considered using the struct iommu_group instead? The struct devices contains a pointer to an iommu_group and the struct itself contains pointers to the domain it is currently bound to. Regards, Joerg -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html