On Tuesday 29 September 2015 11:12:24 Ley Foon Tan wrote: > > > > I think that would be good, yes. We probably picked defaults for the > > asm-generic version that are enough to build with CONFIG_PCI disabled, > > but there are useful defaults for the other case as well. > > > > Most architectures that use the file don't support PCI, so you can just > > add stuff inside of #ifdef CONFIG_PCI. For the remaining 13 architectures > > (git grep -l generic/pci.h | wc), see whether there are conflicts first. > > The normal way would be to have the arch specific definition come before > > the #include, and then do something like > > > > #ifndef pci_proc_domain > > #define pci_proc_domain pci_proc_domain > > static inline int pci_proc_domain(struct pci_bus *bus) > > { > > #ifdef CONFIG_PCI_DOMAINS_GENERIC > > return pci_domain_nr(bus); > > #else > > return 1; > > } > > #endif > > Okay, will try add them to asm-generic. Thanks > Do you prefer to send it as separate patch or can be part of this patchset? I prefer the patches to be part of this series and merged through together with them. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html