> On Sep 15, 2015, at 2:17 PM, Alex Williamson <alex.williamson@xxxxxxxxxx> wrote: > > Also, rather than clearing the flag, can we move the tests done by > pci_vpd_f0_dev_check() into the > quirk setup function? It seems like function 0 should be sufficiently > configured by the time we're probing non-zero functions that we can be > more selective in setting the flag rather than unsetting it later. I guess I was being very conservative in not assuming anything about the state of other devices at that point. Things seem to be increasingly parallel all the time and I am not deeply involved in the evolution of the PCI subsystem. If you want to make that assumption, I would suggest that pci_vpd_f0_dev_check remain a separate function called by the quirk setup so that it can be used by other quirk setup functions as well. -- Mark Rustad, Networking Division, Intel Corporation
Attachment:
signature.asc
Description: Message signed with OpenPGP using GPGMail
