Hi Simon Thank you for your feedback > > From: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@xxxxxxxxxxx> > > > > The reg variable used when setting PCIECAR register need to be masked by 0xFC > > by restriction of the corresponding register. > > This adds PCIE_CONF_REGNO are macros for masking changes that PCIE_CONF_REGNO > > is used when setting PCIECAR register. > > > > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@xxxxxxxxxxx> > > --- (snip) > This seems to partially duplicate the following line earlier on > in rcar_pcie_config_access(). > > reg = where & ~3; > > I wonder if that line could be updated to use the new PCIE_CONF_REGNO() > macro. If so it seems that the second hunk of the patch could be dropped. We double checked this, and yes, you are correct. We don't need this patch. Thank you for pointing it. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
