On Thu, 2015-08-20 at 16:10 -0300, Guilherme G. Piccoli wrote: > On 08/19/2015 10:02 PM, Michael Ellerman wrote: > > In future you should send a reply like the above to my mail, and then > > separately send the new patch series. My preference is that the new series is > > not a reply to anything, though some other maintainers may disagree on that > > point. > > OK, sure. I can send new patch series as new messages instead of replies > to the same thread. Thanks. > > The other question, which I neglected to ask yesterday, is what is the symptom > > of the bug? ie. does the system fail to boot or otherwise crash etc.? > > This is briefly explained on cover-letter, but I can elaborate a bit Sure, but the cover-letter is not committed, so the commit change logs need to be self describing. > more: I was testing driver issues on kernel 2.6.32 (RHEL 6.6), and when > I tried the mainline kernel, the driver wasn't able to enable MSI-X > capabilities. Interestingly, on kernel 4.1 this behavior doesn't happen > and the driver can use MSI-X interrupts. > > So, I figured that something was wrong and found the problem described > on the patches. I tried the proposed solution (calling manually the > function that is not reachable anymore) and it works. > > Regarding the bnx2x driver, below are two dmesg outputs: > > 1) With kernel 4.2-rc7 > bnx2x 0000:01:00.0: no msix capability found OK. This is because the initialisation of dev->msix_cap was lost due to commit 1851617cd2da. > 2) With kernel 4.1 > bnx2x 0000:01:00.0: msix capability found > bnx2x 0000:01:00.0 eth2: using MSI-X IRQs: sp 24 fp[0] 26 ... fp[7] 33 OK. And I assume with these patches you see the above output again. > > This is changes *in* v2, or since v1. > > My bad, sorry. > > > Or anywhere after the first '---', which means the version commentary is > > discarded in the final commit. > > I used scissors, but there's no problem in stop using it in this list. Thanks, but my scripts don't grok scissors. So I prefer the commentary after the '---'. cheers -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
