Re: [PATCH] PCI/ASPM: Fix a NULL pointer crash on sparc64

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 20, 2015 at 10:47 AM, David Miller <davem@xxxxxxxxxxxxx> wrote:
> From: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> Date: Thu, 20 Aug 2015 00:48:00 -0500
>
>> [+cc Dave, Eric, Ben, sparclinux]
>
> I think the comment is terrible.

I'll update the comment if you suggest some text.  Do you object
mainly to the mention of the specific systems?

> It is not limited to those two systems, it is a general problem with
> how the code assumes the root PCI-E port is instantiated in the PCI
> bus hierarchy which will not be true on any system which has a PCI
> controller that doesn't actually provide a bonafide config space to
> access.

I agree, we should not crash if the hardware we find isn't what we expect.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux