On Mon, Aug 17, 2015 at 9:11 PM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote: > On Mon, Jul 27, 2015 at 04:29:45PM -0700, Yinghai Lu wrote: >> So we could unify calculate_iosize and calculate_memsize later. > > Please make this a complete sentence, not just a continuation of the > summary line. > >> when one bridge have several children devices, and every devices >> have several io port resources and resource size < 0x400. > > This isn't a sentence either, so I'm not sure what this is supposed to > mean. will change to: Subject: [PATCH] PCI: Move ISA io port align out of calculate_iosize() We can move ISA io port align out of calculate_iosize(), so we could unify calculate_iosize and calculate_memsize later. That extra aligning or offset is to work around ISA devices: When one bridge have several children devices, and every device has several io port resources and resource size < 0x400. We need to check size, and add extra size to make sure bit8/9 to be zero. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html