On Mon, Aug 17, 2015 at 4:52 PM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote: > On Mon, Jul 27, 2015 at 04:29:25PM -0700, Yinghai Lu wrote: >> After we update size and alignment for must+optional resource, we >> reorder them with new alignment, but this is only for STARTALIGN. >> >> For SIZEALIGN type resource, after add back add_size, the alignment >> get changed, so need to do the sorting like STARTALIGN type resources. >> >> Also we need to reorder the sorting back after we restore >> resource to must only when must+optional fail to allocate for all. >> >> So move out the reordering code from the loop to separated function, >> and call it two times accordingly. >> >> Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx> >> --- >> drivers/pci/setup-bus.c | 62 +++++++++++++++++++++++++++++-------------------- >> 1 file changed, 37 insertions(+), 25 deletions(-) >> >> diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c >> index 7346bbf..6f2d508 100644 >> --- a/drivers/pci/setup-bus.c >> +++ b/drivers/pci/setup-bus.c >> @@ -287,6 +287,31 @@ static inline void reset_resource(struct resource *res) >> res->flags = 0; >> } >> >> +static void __sort_resources(struct list_head *head) > > Why did you add "__" before the function name? ok, will remove that. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
