Re: [RFC PATCH v2] PCI: Only enable IO window if supported

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/29/2015 12:53 PM, Yinghai Lu wrote:
On Wed, Jul 29, 2015 at 12:46 PM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
On 07/29/2015 12:30 PM, Yinghai Lu wrote:


so PCI_BUS_FLAGS_SUPPORTS_IO will never get set.


excellent catch. Unfortunately, I don't know how to make it
work with the reversed flag. The idea here was that the flag
propagates from parent to child. This makes sense for an
"it doesn't work" flag to be inherited from the child,
but not for an "it works" flag.


also would be better if we can add has_ioport in hostbridge instead.
like has_mem64 in https://patchwork.ozlabs.org/patch/500926/
and use

to_pci_host_bridge(bus->bridge)->has_ioport

to replace pci_root_has_io_resource()


Sure, that would make sense.

Bjorn, how do you want to handle the flag problem ?
Do you have an idea on how to make it work with
the reversed definition ?

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux