On Mon, Jul 6, 2015 at 12:31 PM, Rustad, Mark D <mark.d.rustad@xxxxxxxxx> wrote: >> On Jun 26, 2015, at 11:04 AM, Rustad, Mark D <mark.d.rustad@xxxxxxxxx> wrote: >> >>> Sorry, Mark, I've just been busy with other issues and haven't had a >>> chance to look at this yet. >> >> Is there any chance of this getting into this merge window? > > Well, it has missed the merge window, but this really is a bug fix. These patches address problems that, under race conditions, can corrupt VPD data and under other conditions can cause hangs. In fact I would submit that the reason that the VPD operations have been made interruptible is directly related to hangs caused by the sharing of VPD capability registers between functions. You see, if one function ever performs a VPD write, any subsequent read on any other function that shares those registers will definitely hang. As a rule, after the merge window closes, I only merge fixes for things we broke during the merge window or drivers for brand-new things, where there's no chance of breaking something that used to work. It would be nice to have a description of what a user might see when tripping over this problem and maybe some pointers to problem reports. I see it fixes concurrent access problems, and I infer that it's related to sysfs. Feel free to add a stable tag when you post your patches. I'll try to remember to add it when merging this. When it's relevant, it's nice to include the SHA1 of the commit that introduced the bug. But in this case, I think it's been there "forever." Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
