Hi Duc, On 09/07/15 23:12, Duc Dang wrote: > On Tue, Jul 7, 2015 at 10:18 AM, Marc Zyngier <marc.zyngier@xxxxxxx> wrote: >> The XGene MSI driver only uses the msi_controller structure as >> a way to match the host bridge with its MSI HW, and thus the >> msi_domain. >> >> But now that we can directly associate an msi_domain with a device, >> there is no use keeping this msi_controller around. >> >> Just remove all traces of msi_controller from the driver. >> > Thanks, Marc. > > I tested this patch set and it works on my APM X-Gene evaluation platform. Ah, thanks! I did that as a side effort, but didn't have a chance to test it (who the *&%^!! decided to mount this board in a 1U chassis without an angle bracket for the PCIe bus? Seriously???). > The xgene_pcie_msi_enable (in driver/pci/host/pci-xgene.c), which is > used to get msi_controller for X-Gene PCIe port, > also becomes unnecessary with this patch set. I will post a clean-up > patch when your changes are accepted. Yeah, I didn't want to touch too much of it without any testing. > You can add my tested-by if you want: > > Tested-by: Duc Dang <dhdang@xxxxxxx> Thanks a lot for that, M. -- Jazz is not dead. It just smells funny... -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
