On 08/07/15 11:48, Thomas Gleixner wrote:
> On Tue, 7 Jul 2015, Marc Zyngier wrote:
>> +static int its_pci_msi_prepare(struct irq_domain *domain, struct device *dev,
>> + int nvec, msi_alloc_info_t *info)
>> +{
>> + struct pci_dev *pdev;
>> + struct its_pci_alias dev_alias;
>> +
>> + if (!dev_is_pci(dev))
>> + return -EINVAL;
>> +
>> + pdev = to_pci_dev(dev);
>> + dev_alias.pdev = pdev;
>> + dev_alias.count = nvec;
>> +
>> + pci_for_each_dma_alias(pdev, its_get_pci_alias, &dev_alias);
>> +
>> + return its_msi_prepare(domain, dev_alias.dev_id, dev_alias.count, info);
>
> I don't think you need its_msi_prepare() exposed to child
> drivers. Something like
>
> domain->parent->ops->msi_prepare()
>
> should do the trick.
Good point.
I've so far conveniently avoided having an extra set of msi_domain_ops
at the ITS level itself, but that is starting to look like a mistake.
I'll work something out.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
