On Thu, Jun 18, 2015 at 10:02 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
> On Thu, Jun 18, 2015 at 7:26 PM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:
>> On Sat, Jun 13, 2015 at 03:39:02PM -0700, Yinghai Lu wrote:
>>> size = min_size;
>>> if (old_size == 1)
>>> old_size = 0;
>>> + size = ALIGN(size + size1, align);
>>> if (size < old_size)
>>> size = old_size;
>>> - size = ALIGN(size + size1, align);
>>> +
>>
>> Please don't add an extra blank line here; the extra line makes
>> calculate_memsize() look different from calculate_iosize() for no good
>> reason.
>
> Sorry for that. I got the some impression from Ingo or someone else.
> like to have
>
> int func(int a)
> {
> int b;
>
> b = a .....
>
> return b;
> }
>
> aka leave the blank line after declaration/define, and before last return.
I don't really care whether there's a blank line there or not. What I
*do* care about is that we have two functions right next to each other
that are almost identical, and they should *look* the same. If Ingo
likes a blank line there, that's fine; it just needs to be done
consistently. So either add the blank line to both calculate_iosize()
and calculate_memsize() or leave it out of both of them.
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
