On Thu, Jun 11, 2015 at 08:53:46PM +0100, Suravee Suthikulanit wrote:
> For ARM64 PROBE_ONLY and non-PROBE_ONLY modes:
>
> Reviewed and Tested-by: Suravee Suthikulpanit
> <Suravee.Suthikulpanit@xxxxxxx>
Thank you !
> Please see minor comments below.
[...]
> > +static void pci_claim_bridge_resources(struct pci_bus *bus)
> > +{
> > + struct pci_dev *dev = bus->self;
> > + int idx;
> > +
> > + for (idx = PCI_BRIDGE_RESOURCES; idx < PCI_NUM_RESOURCES; idx++) {
> > + struct resource *r = &dev->resource[idx];
> > +
> > + if (!r->flags || r->parent)
> > + continue;
> > +
> > + pci_claim_bridge_resource(dev, idx);
> > + }
> > +}
> > +
>
> Nitpicking: Since pci_claim_bridge_resources() is small, and only called
> once from pci_read_brdige_bases(), should we just put the loop inside
> the function?
I think it is ok to add a function for it, I am not fussed either
way I am more concerned by testing the patch on archs I do not have
access to.
Thank you,
Lorenzo
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
