On Mon, 2015-05-11 at 17:52 +0800, Li, Zhen-Hua wrote: > Add some functions to copy the data from old kernel. > These functions are used to copy context tables and page tables. > > To avoid calling iounmap between spin_lock_irqsave and > spin_unlock_irqrestore, > use a link here, store the pointers , and then use iounmap to free > them in > another place. > > Li, Zhen-hua: > The functions and logics. Surely this isn't specific to the Intel IOMMU? Shouldn't it live elsewhere — either in generic IOMMU code or perhaps in generic kexec support code? Don't we need to solve the same kexec problem on *all* platforms with an IOMMU, and won't they all need something like this? And I think you're misusing VTD_PAGE_{SHIFT,MASK} when you should be using the normal PAGE_{SHIFT,MASK}. And shouldn't physical addresses be phys_addr_t? -- David Woodhouse Open Source Technology Centre David.Woodhouse@xxxxxxxxx Intel Corporation
Attachment:
smime.p7s
Description: S/MIME cryptographic signature