Hi Zhou,
On 05/25/2015 03:48 PM, Jingoo Han wrote:
>so how about we set 0 as default value of pp->root_bus_nr, then use
>pci_create_root_bus(pp->dev, pp->root_bus_nr, &dw_pcie_ops, pp, &res);
>to create root bus?
I agree with your opinion. However, I still want to wait for other
people's opinions. They will give good comments.
Thank you.
Best regards,
Jingoo Han
I did a quick test with your patch in the context of another driver on
arm32.
Just to confirm I added as well pp->root_bus_nr = 0;
Then, I needed to add dummy pci_sys_data as suggested by Arnd in the
first review :
http://www.spinics.net/lists/linux-pci/msg40445.html
struct pcie_port {
+#ifdef CONFIG_ARM
+ /*
+ * this is a temporary hack to let the driver work on
+ * both arm32 and arm64. it can be removed after the
+ * arm32 cleanup is complete and bios32.c has stopped
+ * referencing host->pci_sys_data.
+ */
+ struct pci_sys_data dummy;
+#endif
struct device *dev;
This looks like necessary as bios32 is dereferencing sysdata:
struct pci_sys_data *sysdata = dev->bus->sysdata;
Best Regards,
Fabrice
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
