On Thu, May 21, 2015 at 10:17 AM, Hanjun Guo <hanjun.guo@xxxxxxxxxx> wrote: > On 2015年05月21日 23:10, Bjorn Helgaas wrote: >> >> On Thu, May 21, 2015 at 8:52 AM, Hanjun Guo <hanjun.guo@xxxxxxxxxx> wrote: >>> >>> list_head "list" in struct acpi_prt_entry was used to connect >>> _PRT entries for PCI irq, but after commit 181380b7 (PCI/ACPI: >>> Don't cache _PRT, and don't associate them with bus numbers), >>> the list head for _PRT entries was removed, but left "list" in >>> struct acpi_prt_entry which is useless and stale, remove it now. >> >> >> Please use the canonical commit reference format, i.e., >> >> 181380b702ee ("PCI/ACPI: Don't cache _PRT, and don't associate them >> with bus numbers") > > > OK, now I know what is a canonical commit reference format :) Yeah, it'd be nice if that were better documented. checkpatch complains about it (d311cd44545f ("checkpatch: add test for commit id formatting style in commit log")), but unfortunately I don't think it's mentioned anywhere in Documentation/ Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html