On 05/18/2015 05:00 PM, Mark D Rustad wrote:
Some devices have a problem with concurrent VPD access to different
functions of the same physical device, so move the protecting mutex
from the pci_vpd structure to the pci_bus structure. There are a
number of reports on support sites for a variety of devices from
various vendors getting the "vpd r/w failed" message. This is likely
to at least fix some of them. Thanks to Shannon Nelson for helping
to come up with this approach.
Signed-off-by: Mark Rustad <mark.d.rustad@xxxxxxxxx>
Acked-by: Shannon Nelson <shannon.nelson@xxxxxxxxx>
Acked-by: Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx>
Instead of moving the mutex lock around you would be much better served
by simply removing the duplicate VPD entries for a given device in a
PCIe quirk. Then you can save yourself the extra pain and effort of
having to deal with serialized VPD accesses for a multifunction device.
The logic for the quirk should be fairly simple.
1. Scan for any other devices with VPD that share the same bus and
device number.
2. If bdf is equal to us keep searching.
3. If bdf is less than our bdf we release our VPD area and set VPD
pointer to NULL.
- Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
