On Thu, 7 May 2015, Jiang Liu wrote:
> Once PCI MSI/MSI-X is enabled by the device driver, PCI device won't
> make use of legacy PCI IRQ until PCI MSI/MSI-X is disabled again.
> So optionally free legacy PCI IRQ when enabling MSI/MSI-X and reallocate
> when disabling MSI/MSI-X.
This is a bit odd. With your proposed change we'll have:
alloc_legacy_irq()
msi[x]_enable()
free_legacy_irq()
msi[x]_disable()
alloc_legacy_irq()
And after that we shut down the device which will free the legacy irq
again.
Shouldn't we allocate the legacy irq only if we really need it?
Thanks,
tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
