> -----Original Message----- > From: Bjorn Helgaas [mailto:bhelgaas@xxxxxxxxxx] > Sent: Thursday, May 7, 2015 10:08 AM > To: William Davis > Cc: joro@xxxxxxxxxx; iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx; linux- > pci@xxxxxxxxxxxxxxx; Terence Ripperda; John Hubbard; jglisse@xxxxxxxxxx > Subject: Re: [PATCH 6/6] x86: add pci-nommu implementation of map_resource > > On Fri, May 01, 2015 at 01:32:18PM -0500, wdavis@xxxxxxxxxx wrote: > > From: Will Davis <wdavis@xxxxxxxxxx> > > > > diff --git a/arch/x86/kernel/pci-nommu.c b/arch/x86/kernel/pci-nommu.c > > index da15918..6e9e66d 100644 > > --- a/arch/x86/kernel/pci-nommu.c > > +++ b/arch/x86/kernel/pci-nommu.c > > @@ -38,6 +38,22 @@ static dma_addr_t nommu_map_page(struct device *dev, > struct page *page, > > return bus; > > } > > > > +static dma_addr_t nommu_map_resource(struct device *dev, struct resource > *res, > > + unsigned long offset, size_t size, > > + enum dma_data_direction dir, > > + struct dma_attrs *attrs) > > +{ > > + dma_addr_t bus = res->start + offset; > > "res->start" is the CPU physical address, not the bus address. There is a > pci_bus_address() interface to get the bus address. > > On many, but not all, x86 platforms the CPU physical address is identical > to the PCI bus address. > Thanks for pointing that out. Since we already have the resource here (and not the BAR index), I'll use pcibios_resource_to_bus(), as pci_bus_address() does. Thanks, Will -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
