On 4/29/15 12:43, Lorenzo Pieralisi wrote:
On Wed, Apr 29, 2015 at 01:34:20PM +0100, Arnd Bergmann wrote:
>On Wednesday 29 April 2015 17:09:58 Jayachandran C wrote:
> >The current code in pci-host-generic.c uses pci_common_init_dev()
> >from the arch/arm/ to do a part of the PCI initialization, and this
> >prevents it from being used on arm64.
> >
> >The initialization done by pci_common_init_dev() that is really
> >needed by pci-host-generic.c can be done in the same file without
> >using the hw_pci API of ARM.
> >
> >The ARM platform requires a pci_sys_data as sysdata for the PCI bus,
> >this is be handled by setting up 'struct gen_pci' to embed a
> >pci_sys_data variable as the first element on the ARM platform.
> >
> >Signed-off-by: Jayachandran C<jchandra@xxxxxxxxxxxx>
>
>This seems very useful
Yes, it is getting less awful, waiting for pci_sys_data to disappear.
Lorenzo,
A while back, you mentioned here (https://lkml.org/lkml/2015/2/16/364)
that the ARM32 pcibios_align_resource() implementation requires
pci_sys_data, so we _still_ rely on pci_common_init_dev to create one
for us. Is this still the case?
I am looking at the arch/arm32/kernel/bios32.c: pcibios_init_hw() and
see that it setup the pci_sys_data.align_resource to
hw_pci.align_resource (see here
http://lxr.free-electrons.com/source/arch/arm/kernel/bios32.c#L471).
However it seems that the hw_pci.align_resource is never setup in the
pci-host-generic.c. Am I missing something here?
Thanks,
Suravee
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
