On Thu, Apr 30, 2015 at 07:27:23PM +0200, Luis R. Rodriguez wrote: > On Thu, Apr 30, 2015 at 11:26:47AM -0500, Bjorn Helgaas wrote: > > I don't see users of either pcim_iomap_wc() or pcim_iomap_wc_regions() so > > far. Did I miss them, or do you just expect them in the near future? > > The later, and also I hate seeing folks later add code under EXPORT_SYMBOL() > rather than EXPORT_SYMBOL_GPL() so I figure I'd rather do it first. It happened > recently in my v1 series, someone beat me to a write-combining export symbol > and changed it to EXPORT_SYMBOL(). Feel free to drop this though but I hope > no one out there then tries to just add an EXPORT_SYMBOL() later for this... Why do you want them to be EXPORT_SYMBOL_GPL? I would expect them to be exported the same way pcim_iomap(), pcim_iomap_regions(), and ioremap_wc() are exported, i.e., with EXPORT_SYMBOL. Per Documentation/DocBook/kernel-hacking.tmpl, EXPORT_SYMBOL_GPL "implies that the function is considered an internal implementation issue, and not really an interface." I don't think these are internal implementation issues. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
