On Wed, Apr 29, 2015 at 8:33 AM, Jiang Liu <jiang.liu@xxxxxxxxxxxxxxx> wrote: > On 2015/4/29 21:20, Bjorn Helgaas wrote: >> On Tue, Apr 28, 2015 at 7:40 PM, Rafael J. Wysocki <rjw@xxxxxxxxxxxxx> wrote: >>> On Monday, April 20, 2015 11:08:58 AM Jiang Liu wrote: >>>> + * >>>> + * Another possible solution is to explicitly filter out IO >>>> + * port[0xCF8-0xCFF]. >>>> + */ >>>> + res_flags = IORESOURCE_IO | IORESOURCE_MEM | IORESOURCE_IO_FIXED; >> >> 2) The usage of IORESOURCE_IO_FIXED here seems like a hack. It's not >> related to other existing use of IORESOURCE_IO_FIXED, and it's not >> intuitive that supplying IORESOURCE_MEM means "I want all the >> memory-type resources," but supplying IORESOURCE_IO_FIXED means "I >> *don't* want the fixed I/O-type resources." > > Yes, the IORESOURCE_IO_FIXED is a hack here. Then how about explicitly > filtering IOPORT [0xCF8-0xCFF] so we could avoid such a hack. I'm OK with that, although it should be in an arch-specific hook or something. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
